[Make:Voter] Add Missing Vote param in voteOnAttribute()#1759
Open
ayyoub-afwallah wants to merge 1 commit intosymfony:1.xfrom
Open
[Make:Voter] Add Missing Vote param in voteOnAttribute()#1759ayyoub-afwallah wants to merge 1 commit intosymfony:1.xfrom
voteOnAttribute()#1759ayyoub-afwallah wants to merge 1 commit intosymfony:1.xfrom
Conversation
ayyoub-afwallah
force-pushed
the
fix/missing-vote-param-in-voter-template
branch
2 times, most recently
from
58e368e to
f171762
Compare
ayyoub-afwallah
force-pushed
the
fix/missing-vote-param-in-voter-template
branch
from
f171762 to
e61fecb
Compare
Contributor
Author
|
@javiereguiluz can you take a look at this one? Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #59771 and #61187.
Starting from Symfony 8.0, running
make:votergenerates a deprecated declaration that triggers the following error :This PR updates the template to match the new declaration.